Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support list of parameter values in Forcefield XML #681

Merged

Conversation

umesh-timalsina
Copy link
Member

Closes #674.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #681 (4b60bbd) into develop (2970412) will increase coverage by 0.01%.
The diff coverage is 87.50%.

@@             Coverage Diff             @@
##           develop     #681      +/-   ##
===========================================
+ Coverage    91.20%   91.21%   +0.01%     
===========================================
  Files           63       63              
  Lines         5160     5170      +10     
===========================================
+ Hits          4706     4716      +10     
  Misses         454      454              
Impacted Files Coverage Δ
gmso/utils/ff_utils.py 96.01% <87.50%> (-0.30%) ⬇️
gmso/formats/mol2.py 100.00% <0.00%> (ø)
gmso/core/atom_type.py 97.36% <0.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2970412...4b60bbd. Read the comment docs.

@daico007 daico007 merged commit cc23eb8 into mosdef-hub:develop Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants